Hi Paul, note this is a lower-case review. Having looked at 8151705, thumbs up for this one as well - they go hand in hand and looking at one of them only doesn't feel right. :-)
Best, Michael > Am 08.04.2016 um 11:56 schrieb Paul Sandoz <paul.san...@oracle.com>: > > Hi, > > Please review: > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151706-VH-form-table-stable/webrev/ > > <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8151706-VH-form-table-stable/webrev/> > > Now that @Stable arrays are supported by C1 (thanks Vladimir!) we can switch > from the explicit use of MemberName fields in VarForm to a @Stable > MemberName[] array. > > I also took the opportunity to simplify the linking from a VarHandle impl to > MemberName[] array, now that the implementation has settled down. This will > reduce initialization costs and memory churn. > > > I held off making further improvements for now. For example, VarForm can > probably go away (also removing the dependency on ClassValue). A VarHandle > instance can directly hold a MemberName[] array whose source reference is > statically held on the associated VarHandle implementation. It should also be > possible to lazily create MemberName instances as required, rather than > aggressively doing so, which may further reduce initialization costs and > memory usage in common cases. > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
