> On 12 Apr 2016, at 10:18, Claes Redestad <claes.redes...@oracle.com> wrote: > > Hi Steve, > > On 2016-04-11 23:21, Steve Drach wrote: >> Hi, >> >> I’ve updated the following patch, incorporating code by Claes Redestad to >> handle some corner cases while processing the attribute value. Note that >> we’ve limited the location of the value part of the attribute to accommodate >> startup performance requirements. It’s not without precedent as at least >> one other attribute is also limited in amount of whitespace surrounding the >> value. >> >>> Please review this simple fix to require that the jar manifest >>> Multi-Release attribute has a value of “true" in order to be effective, >>> i.e. to assert the jar is a multi-release jar. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8153213 >> <https://bugs.openjdk.java.net/browse/JDK-8153213> >> webrev: http://cr.openjdk.java.net/~sdrach/8153213/webrev.01/index.html >> <http://cr.openjdk.java.net/%7Esdrach/8153213/webrev.01/index.html> >> > > this looks good to me.
Same here, and i like the additional tests. I think we have beaten this into submission at this point :-) Paul. > Good catch to delete the new jars added by the test. > > I'll sponsor this for you once tests look OK. > > Thanks! > > /Claes > >> >> Thanks >> Steve >