Thanks Lance!

On 4/12/2016 12:28 PM, Lance Andersen wrote:
Looks OK Joe.

Best
Lance
On Apr 8, 2016, at 4:49 PM, huizhe wang <huizhe.w...@oracle.com <mailto:huizhe.w...@oracle.com>> wrote:

Hi,

Please review a fix for the issue that caused public entries not being searched when prefer='system'. When prefer='system', the Catalog standard only required that public entries were not searched if there is a system identifier.

I added tests to reflect a combination of the settings of prefer, identifier(s), and entry types (public and/or system). The test "matchWithPrefer" covered the three test cases in the JCK mentioned in the bug report plus 9 other scenarios, while "resolveWithPrefer" covered 18 resolution scenarios by a CatalogResolver.

JBS: https://bugs.openjdk.java.net/browse/JDK-8151162
Webrev: http://cr.openjdk.java.net/~joehw/jdk9/8151162/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8151162/webrev/>

Thanks,
Joe

<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>




Reply via email to