Hi Chris, FWIW changes looks good to me.
cheers /Joel On Wed, 13 Apr 2016 at 17:43 Chris Hegarty <chris.hega...@oracle.com> wrote: > This review is for the second significant part of the changes for JEP > 260 [1]. When created, the jdk.unsupported module [2] initially > contained the sun.misc package. This issue is will move all the > non-Critical APIs out of sun.reflect, leaving only the critical ones, at > which point sun.reflect can be moved to the jdk.unsupported module. > > http://cr.openjdk.java.net/~chegar/8137058/ > https://bugs.openjdk.java.net/browse/JDK-8137058 > > Summary of the changes: > > - Move all existing sun.reflect types to jdk.internal.reflect, and > fix up references in the libraries, and the VM, to use the new internal > location. > > - Update tests, as appropriate, to use the new location. > > - Add the minimal set of critical APIs to jdk.unsupported/sun.reflect. > These ultimately delegate to the internal versions. Additionally, a > few new tests have been added to exercise these. > > -Chris. > > [1] https://bugs.openjdk.java.net/browse/JDK-8132928 > [2] https://bugs.openjdk.java.net/browse/JDK-8153737 >
