On 14/04/2016 09:53, Paul Sandoz wrote:
Hi Sherman,
Not a full review, I browsed the code very quickly and noticed one thing:
JrtFileSystem
—
167 private static final Set<String> supportedFileAttributeViews
168 = Collections.unmodifiableSet(
169 new HashSet<String>(Arrays.asList("basic", "jrt")));
Use Set.of.
One constraint that Sherman didn't mention is that jrtfs is compiled to
JDK N-1, currently JDK 8, so that tools/IDEs can run on JDK 8 and access
the classes/resources in a target JDK 9 runtime image. I thought we put
a comment at the top of each source file on this but I need to check. It
will be caught by the build anyway.
-Alan.
