On 4/14/16 6:49 AM, Lance Andersen wrote:
Outside of the comments from Remi regarding ASM, the other changes look fine to me and the wordsmithing looks good.
Hi Lance, thanks for the looking this over.
I assume we are going to want to go back and add the JDK release of deprecation for all methods. If so, I will get to the JDBC ones shortly.
It's not strictly required to add the since="x" element to every occurrence of the @Deprecated annotation, but it would be nice to do so if there is time. This is mainly up to the maintainer of each area. It also requires some research to determine the release value to put there.
At some point we'll want to make sure that everything in the JDK is fully annotated, but that's a longer term effort.
s'marks
