On 4/19/2016 1:45 PM, Langer, Christoph wrote:
Hi Joe,
I've updated the testcase to increase the probability of it really hitting the
issue. The old version was prone to miss the issue in case something changed in
the parser.
http://cr.openjdk.java.net/~clanger/webrevs/8153781.2/
Looks good overall.
OK, thanks.
Error msgs: you made an extra effort :-) normally, we don't need to do
any translation. The I18n team has a revolving task that will
periodically pick up these changes.
OK - I think the message is not really useful anyway. I don't see a way to
produce it by creating a malformed XML document. It would probably only pop up
with the old erroneous implementation of skipDTD and SUPPORT_DTD property false.
License header: it is correct to update to the latest Apache License
format. However, we would need to preserve the "reserved comment block"
if we've not changed the code, which is the case for class such as
HTTPInputSource.java.
Fixed that.
Here is the new webrev: http://cr.openjdk.java.net/~clanger/webrevs/8153781.3/
If you consider it reviewed I would love if you could push it for me. :-)
Sure :-) Will do after all test runs complete.
Thanks,
Joe
Thanks
Christoph
