Hi Claes, thanks for this one as well; see http://cr.openjdk.java.net/~mhaupt/8154754/webrev.01/ for an updated webrev. This patch still depends on the one for 8154751.
Best, Michael > Am 22.04.2016 um 12:18 schrieb Claes Redestad <[email protected]>: > > Hi, > > looks good to me. resultType == void.class ? zero(void.class) : > identity(resultType) appears twice and unconditionally used at least once, > thus could be profitably extracted to a variable for readability/imaginary > performance gain. Thanks! /Claes > > On 2016-04-20 15:46, Michael Haupt wrote: >> Dear all, >> >> please review this change. It depends on the one about 8154751 posted >> earlier [1]. >> Bug: https://bugs.openjdk.java.net/browse/JDK-8154754 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8154754/webrev.00/ >> >> Thanks, >> >> Michael >> >> [1] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-April/040386.html >> > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
