On 04/26/2016 04:56 PM, Alan Bateman wrote:
On 26/04/2016 15:42, Peter Levart wrote:
I increased the timeout to 30 seconds. It is not exactly 30 seconds,
but 300 iterations with sleep(100L) + check in each iteration. If the
system is really overloaded then this loop should stretch automatically:
http://cr.openjdk.java.net/~plevart/jdk9-dev/Module.WeakSet.multithreadUnsafe/webrev.05/
Are there any other jigsaw-specific tests I should be paying close
attention to? I ran the jdk/test/java/lang/reflect/WeakPairMap
jdk/test/java/lang/reflect/Module and jdk/test/java/lang/Class tests.
Will I need an official blessing to push this to jdk9/dev on the
core-libs-dev as we have been discussing this patch only on
jigsaw-dev for a while?
I think this version is okay. We'll have to see if 30s is enough as
we've hit some very long timeouts in the past due to interference from
other things on the system.
I realize I suggested jdk9/dev for this now I wonder it might be
better to pull this into the jake forest so as to avoid merging + code
changes. We are accumulating several module code changes to bring into
jdk9/dev in bulk, mostly it is changes that cannot go into jdk9/dev
now because they are dependent on changes to jtreg (that is rev'ing in
tandem). There are also changes that will need a few iterations before
we are ready to bring them to JDK 9. If we are okay with that then I
can sponsor it for you.
-Alan
Ok, Alan, then I leave it to you to push it at your convenience.
Thanks.
Regards, Peter