> On 29 Apr 2016, at 15:12, Aleksey Shipilev <aleksey.shipi...@oracle.com>
> wrote:
>
> Hi,
>
> I would like to fix a simple testbug in our weakCompareAndSet VarHandles
> and Unsafe intrinsics tests. weakCompareAndSet is spec-ed to allow
> spurious failures, but current tests do not allow that. This blocks
> development and testing on non-x86 platforms.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8155739
>
> Webrevs:
> http://cr.openjdk.java.net/~shade/8155739/webrev.hs.00/
> http://cr.openjdk.java.net/~shade/8155739/webrev.jdk.00/
>
Looks good.
Small tweak if you so wish to do so:
#if[JdkInternalMisc]
static final int WEAK_ATTEMPTS = Integer.getInteger("weakAttempts", 10);
#end[JdkInternalMisc]
which avoids changes to the SunMiscUnsafe* tests.
Paul.
> The tests are auto-generated, and the substantiative changes are in
> *.template files. I also removed obsolete generate-unsafe-tests.sh. I
> would like to push through hs-comp to expose this to Power and AArch64
> folks early.
>
> Testing: x86_64, jdk:java/lang/invoke/VarHandle, hotspot:compiler/unsafe
>
> Thanks,
> -Aleksey
>
