Hi Brian,
In the @throws IndexOutOfBounds I think it is easier to understand to say
* or {@code off + len} is greater than {@code cbuf.length}
It matches the code more closely.
- Is not clear why the form of the added @throws is different between
the methods (other than len = string.size()
line 214: add a spaces in "off+len"
Most/All files have the same pattern. It would be nice to be consistent.
Thanks, Roger
On 5/4/2016 7:17 PM, Brian Burkhalter wrote:
Please review at your convenience.
Issue: https://bugs.openjdk.java.net/browse/JDK-8130679
Patch: http://cr.openjdk.java.net/~bpb/8130679/webrev.00/
Summary: Add “@throws IndexOutOfBoundsException […]” to all write() methods
which accept an index parameter and for which no such throws tag is already
present.
Thanks,
Brian
