Hi Vladimir, pushed already. I'll piggyback this on a future change.
Best, Michael > Am 18.05.2016 um 11:47 schrieb Vladimir Ivanov <vladimir.x.iva...@oracle.com>: > > src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java > + throw new AssertionError(); > > + throw new IllegalStateException("should not reach here"); > > Please, use InternalError to signal about error conditions (there's > MHS.newInternalError(String)) and put a message containing description of > problematic parameters to simplify problem diagnostics. > > Otherwise, looks good! > > Best regards, > Vladimir Ivanov > > On 5/18/16 10:52 AM, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webrev.00/ >> >> Thanks, >> >> Michael >> -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment