> On May 25, 2016, at 12:24 PM, Jiangli Zhou <jiangli.z...@oracle.com> wrote:
> 
> Hi Mandy,
> 
>> On May 25, 2016, at 12:17 PM, Mandy Chung <mandy.ch...@oracle.com> wrote:
>> 
>> 
>>> On May 25, 2016, at 11:28 AM, Jiangli Zhou <jiangli.z...@oracle.com> wrote:
>>> 
>>> Here is the updated webrev:
>>> 
>>> http://cr.openjdk.java.net/~jiangli/8157716/webrev.01/
>> 
>> The version restoring toRealPath looks okay.
> 
> Thanks for the review.
> 
>> 
>> I think the proposed toFileURL method name is fine and perhaps the javadoc 
>> of toFileURL method could make it clearer.  If we had to rename it, maybe 
>> toRealPathFileURL (mouthful but it clearly shows it’s “real path” as 
>> specified in java.nio.file.Path).
> 
> I discussed with Alan. We will keep the proposed toFileURL method name for 
> now.

That’s fine with me.

Mandy

Reply via email to