> On 26 May 2016, at 23:51, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > > http://cr.openjdk.java.net/~shurailine/8157996/webrev.01/
Looks good Shura. > Thank you. > > Shura > >> On May 26, 2016, at 3:29 PM, Alexandre (Shura) Iline >> <alexandre.il...@oracle.com> wrote: >> >> >>> On May 26, 2016, at 3:16 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >>> >>> >>>> On May 26, 2016, at 2:30 PM, Alexandre (Shura) Iline >>>> <alexandre.il...@oracle.com> wrote: >>>> >>>> Hi. >>>> >>>> Please take a look on an obvious fix: >>>> http://cr.openjdk.java.net/~shurailine/8157996/webrev.00/ >>>> >>>> There was an unneeded import statement which was getting in the way when >>>> running tests with limited module availability. >>>> >>>> Also in a couple of places I have added try with resources. >>> >>> Looks okay. Can you take out the extra space between “init” and “(“ while >>> you are on this file? >>> 65 init (fis); >> >> Then I am taking out all extra spaces in this code. Per the examples in >> http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html. :) >> >> I was thinking whether to do it to not. I have removed the extra spaces in other areas too. It is a particular, IMHO bad, style that some engineers follow. -Chris.
