Sorry, uploaded the previous diff again by mistake, updated in-place now.
On 2016-06-28 00:04, Mandy Chung wrote:
On Jun 27, 2016, at 2:43 PM, Claes Redestad <claes.redes...@oracle.com> wrote:
To accommodate your change request w.r.t. unmodifiableList above I took the
liberty of cleaning up VersionBuilder.parse() a bit, though. Hope you don't
mind:
http://cr.openjdk.java.net/~redestad/8160000/webrev.6/
Moving Collections.unmodifiableList to the Version constructor is a good idea.
But I don’t see that change in the webrev.6 though - is that updated?
940 List<Integer> versionNumbers = VersionProps.versionNumbers();
941 version = new
Version(Collections.unmodifiableList(versionNumbers),
942 VersionProps.pre(),
943 VersionProps.build(),
944 VersionProps.optional());
1090 this.version = version;
1509 version = Collections.unmodifiableList(list);
Mandy
