Hi,
On 2016-07-13 15:12, Michael Haupt wrote:
Dear all,
please review this fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8161212
Webrev: http://cr.openjdk.java.net/~mhaupt/8161212/webrev.00/
fix looks OK, but I'm genuinely curious about best practice when it
comes to pass arguments to jtreg tests. How do I even pass -run to the
actual test?
Naively System properties seems easier and possibly less fragile
(assuming tests aren't run with a very strict security policy somewhere
so that we'd have to pair the test with the associated permissions):
jtreg ... -Djava.lang.invoke.LoopCombinatorLongSignatureTest.run
java/lang/invoke/LoopCombinatorLongSignatureTest.java
boolean run =
System.getProperty("java.lang.invoke.LoopCombinatorLongSignatureTest.run")
!= null;
Thanks!
/Claes
Running the test in LambdaForm interpretation mode takes a long time. As the
test is actually about capturing excessively long loop clause lists, running
the constructed loop should be optional. The fix disables running the loop by
default and introduces a -run option that can be used if the loop should
actually be run.
Thanks,
Michael