Thanks Ivan. I've already pushed the fix, so I created a new one (JDK-8162343)

Naoto

On 7/21/16 5:59 AM, Ivan Gerasimov wrote:
Hi Naoto!

I see that the same non-ASCII chars are used in
src/java.base/share/native/libjimage/jimage.hpp
and in
src/java.base/share/native/libjimage/imageDecompressor.hpp

It might make sense to change them as well.

With kind regards,
Ivan



On 20.07.2016 22:51, Naoto Sato wrote:
Hello,

Please review this small fix for the following issue:

https://bugs.openjdk.java.net/browse/JDK-8161937

The proposed fix is located at:

http://cr.openjdk.java.net/~naoto/8161937/webrev.00/

This is just to replace those non-ASCII characters used in comments
with the equivalents in ASCII range. It's hard to tell the difference
from the webrev above, but the change replaced the following characters:

U+2014 (EM DASH) -> U+002D (HYPHEN-MINUS -)
U+2019 (RIGHT SINGLE QUOTATION MARK) -> U+0027 (APOSTROPHE ')
U+201C (LEFT DOUBLE QUOTATION MARK) -> U+0022 (QUOTATION MARK ")
U+201D (RIGHT DOUBLE QUOTATION MARK) -> U+0022 (QUOTATION MARK ")

Naoto


Reply via email to