Hi, looking good. I believe you could also remove the comment sections after the headers like: /* * $Id: Constants.java,v 1.7 2006/06/19 19:49:04 spericas Exp $ */
But no need for new webrev for that, of course :-) Best regards Christoph > -----Original Message----- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Montag, 25. Juli 2016 19:22 > To: Langer, Christoph <christoph.lan...@sap.com>; Joe Wang > <huizhe.w...@oracle.com>; Alan Bateman <alan.bate...@oracle.com> > Cc: core-libs-dev <core-libs-dev@openjdk.java.net> > Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes > that invoke addReads > > Hi, > > Here is the later version of the fix: > > - Header files fixed > - Bytecode 1.1 compatible > > http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.02/ > > cheers, > > -- daniel > > On 25/07/16 16:16, Langer, Christoph wrote: > > Hi Daniel, > > > > yes, I just recognized the header is different everywhere. It is a good > > idea to > consult Joe on this - he was also giving me hints on how to do it correctly > when I > was touching JAXP. > > > > Best regards > > Christoph > > > >> -----Original Message----- > >> From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > >> Sent: Montag, 25. Juli 2016 16:43 > >> To: Langer, Christoph <christoph.lan...@sap.com> > >> Cc: Joe Wang <huizhe.w...@oracle.com>; core-libs-dev <core-libs- > >> d...@openjdk.java.net> > >> Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes > >> that invoke addReads > >> > >> Hi Christoph, > >> > >> On 22/07/16 20:23, Langer, Christoph wrote: > >>> Hi Daniel, > >>> > >>> looks good to me. > >>> > >>> Maybe you'll want to take the chance to update the apache headers in the > >> xalan files? > >>> > >> > >> Thanks for your review! > >> > >> I'm only an occasional wanderer in JAXP land - which files do you see > >> have an outdated header? > >> > >> I'll try to ping Joe Wang to get the correct headers. > >> > >> best regards, > >> > >> -- daniel
