Looks fine; thanks,

-Joe


On 8/10/2016 11:30 PM, John Jiang wrote:
Hi,
Please review another updated webrev:
http://cr.openjdk.java.net/~jjiang/8160611/webrev.02/

com/sun/jdi/JdbMethodExitTest.sh 8031555 generic-all
The above line shouldn't be removed, and 8031555 should be replaced by 6902121. Because JDK-8031555 is closed as a duplicate of JDK-6902121, which is still open.

Best regards,
John Jiang


On 2016/8/9 21:17, John Jiang wrote:
Hi Daniel,
Thanks for your review!

Please take a look at this updated webrev:
http://cr.openjdk.java.net/~jjiang/8160611/webrev.01/

Best regards,
John Jiang


On 2016/8/9 17:53, Daniel Fuchs wrote:
Hi John,

JDK-8061177 [1] has been resolved as a duplicate of
JDK-8065756 [2] which is still open.
The correct action for this one might be to leave the
test in the problem list but change the bug ID.

The rest looks good to me - even though
two of these test have been fixed by either adding
diagnosis information or fixed as 'Cannot Reproduce'.

Since most of these tests are in the serviceability
area however, it might be good to get someone from
serviceability-dev (added in cc:) to confirm whether
they want to get these out of the problem list.

best regards,

[1] https://bugs.openjdk.java.net/browse/JDK-8061177
[2] https://bugs.openjdk.java.net/browse/JDK-8065756

-- daniel

On 09/08/16 09:34, John Jiang wrote:
Hi,
The below issues have been closed,
    JDK-8130339, JDK-8068645, JDK-8061177, JDK-8058616, JDK-8046285,
JDK-8031555
but the associated items still be contained by ProblemList.txt. This
small patch removes them.

Issue: https://bugs.openjdk.java.net/browse/JDK-8160611
Webrev: http://cr.openjdk.java.net/~jjiang/8160611/webrev.00

Best regards,
John Jiang







Reply via email to