> On Aug 8, 2016, at 6:25 PM, Kim Barrett <kim.barr...@oracle.com> wrote:
>
> full: http://cr.openjdk.java.net/~kbarrett/8156500/jdk.04/
> http://cr.openjdk.java.net/~kbarrett/8156500/hotspot.04/
This looks very good.
Have you considered having JVM_WaitForReferencePendingList method to return the
pending list? i.e. make it a blocking version of
getAndClearReferencePendingList rather than two operations.
waitForReferenceProcessing is really wait for pending reference(s) enqueued
(additionally cleaner gets invoked). What do you think to rename this method
to “waitForPendingReferencesEnqueued”?
Grammar question:
"there are no more references”
"If there aren't any pending {@link Reference}s"
- This is the case with zero pending reference, shouldn’t it use “is” such that:
"there us no more reference”
"If there isn't any pending {@link Reference}”
Please update the synposis of JDK-8156500 to make it clear what this fix is
(it’s nothing related to JDI). Maybe something like “Move the pending
reference list to VM”
Mandy
