Hi Joe,
Thank you for reviewing the changes. I found one more inconsistency with
these tests:
The TestSAXDriver class is not compiled by default now and because of
that the default SAX driver were used and the original issue was not
reproduced properly. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8150145/01
About intermittent failure: The test was added with 'othervm' initially,
but few months ago the transformation test was failing due to
concurrency issue in PackageEntry::package_exports_do ( JDK-8152404).
Now failures are not reproducible with latest JDK9 builds and latest
version of the tests.
-Aleksej
On 31/08/16 19:25, Joe Wang wrote:
Hi Aleksej,
It's good to put the tests back online. Thanks for the diligent work!
I believe the change that made the tests run in othervm could have
fixed the intermittent issue. But adding debugging code can always be
helpful in case of failures.
Thanks,
Joe
On 8/30/16, 12:01 PM, Aleks Efimov wrote:
Hello,
Please, help to review the tests fix.
Webrev: http://cr.openjdk.java.net/~aefimov/8150145/00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8150145
The list of changes:
1. Two tests were modified to print exception occurred during
execution. Before that these tests were failing silently.
2. The tests were slightly modified to correctly run with security
manager run mode recently added to JAXP tests (JDK-8067170).
3. TransformationWarningsTest were modified to synchronize the
TransformerFactory instantiation.
The modified tests were executed 2000+ times (alongside to other
tests from jaxp/test/javax/xml/jaxp/unittest/common) on linux-x64 and
there were no failures observed. According to this result and that
the tests were modified not to fail silently. I would like to remove
these two tests from the jaxp problem list.
If the tests will continue to fail on some configurations (JPRT shows
no failures for few runs though) the proposed changes will help to
diagnose the cause of failures.
With Best Regards,
Aleksej
