Hi Ivan,
In the TestBase64.java:
563 throw new RuntimeException("Expected IOOBEx not thrown"); And
598 throw new RuntimeException("Expected IOOBEx not thrown");
I would say "was not thrown" to make the cause clearer. 567 throw new
RuntimeException("No output expected"); I suppose this will never fail
but including the size in the exception message would speed debugging.
Otherwise, looks fine Roger
On 9/2/16 4:59 AM, Ivan Gerasimov wrote:
Thank you Roger and Alan for review! On 01.09.2016 20:39, Alan Bateman
wrote:
TestBase64 is the unit test for this API, should the test be added to
that instead?
Yes, it should be better.
http://cr.openjdk.java.net/~igerasim/8165243/01/webrev/ I also added
another test case to make sure the decoder doesn't expose the same
bug. A cleanup pass was performed to make the code more compact. Is it
good to go? With kind regards, Ivan
