Hi Joe,


 603     /**
 604      * Returns the text of the first element found by the reader.
 605      * @param streamReader the XMLStreamReader
 606      * @return the text of the first element
 607      * @throws XMLStreamException
 608      */
609 String getText(XMLStreamReader streamReader, int type) throws XMLStreamException {

It would be good to update the javadoc of this method (in particular
document the new 'type' parameter) so that future maintainer
can understand what that method is supposed to do.

In particular would it be OK to encounter both CHARACTERS and
ENTITY_REFERENCE, or are these exclusive. If they are should some
exception be thrown?

I can't say I understand how the new test works, but nothing
else jumped at me in your webrev :-)

best regards,

-- daniel

On 19/09/16 20:11, Joe Wang wrote:

Please review an addition of StAX tests to the Catalog Support test set.

JBS: https://bugs.openjdk.java.net/browse/JDK-8166220
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8166220/webrev/


Reply via email to