On 21 Sep 2016, at 20:33, Martin Buchholz <marti...@google.com> wrote: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > > Notable here is an attempt to make a minimal completion stage more acceptable > as a return value from APIs, by making > completableFuture.minimalCompletionStage().toCompletableFuture() useful.
Looks good. CompletableFuture.minimalCompletionStage().toCompletableFuture(), this is subtle. I think what you have is right. Thankfully CS::toCompletableFuture allows this; "If this stage is already a CompletableFuture, this method MAY return this stage itself." Can you please check the indentation in testCopy_normalCompletion and testCopy_exceptionalCompletion. -Chris.
