Re: RFR 8166501 : compilation error in stackwalk.cpp on some gccs

[Dmitry Samersoff]

Brent,

Looks good for me.

-Dmitry

On 2016-09-22 19:04, Brent Christian wrote:
> Hi,
> 
> Looks like my 8165372 change broke the slowdebug build.  Please review
> my fix (which also breaks up a pretty long line):
> 
> --- a/src/share/vm/prims/stackwalk.cpp
> +++ b/src/share/vm/prims/stackwalk.cpp
> @@ -331,10 +331,12 @@
>      assert (use_frames_array(mode), "Bad mode for get live frame");
>      RegisterMap regMap(jt, true);
>      LiveFrameStream stream(jt, &regMap);
> -    return fetchFirstBatch(stream, stackStream, mode, skip_frames,
> frame_count, start_index, frames_array, CHECK_NULL);
> +    return fetchFirstBatch(stream, stackStream, mode, skip_frames,
> frame_count,
> +                           start_index, frames_array, THREAD);
>    } else {
>      JavaFrameStream stream(jt, mode);
> -    return fetchFirstBatch(stream, stackStream, mode, skip_frames,
> frame_count, start_index, frames_array, CHECK_NULL);
> +    return fetchFirstBatch(stream, stackStream, mode, skip_frames,
> frame_count,
> +                           start_index, frames_array, THREAD);
>    }
>  }
> 
> Thanks!
> -Brent
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.