On Fri, Sep 23, 2016 at 8:11 AM, David Holmes <david.hol...@oracle.com> wrote: > Hi Goetz, > > I see a change not related directly to S390 ie change from ARM to ARM32 in > src/os/linux/vm/os_linux.cpp >
The change looks a little confusing because Goetz reordered the ifdef cascades alphabetically (which I think is good). Besides that, the only real change not related to s390 is indeed the change from ARM to ARM32 which happend two times in the file. @Goetz: have you done this intentionally? > It will be a while before I can go through this in any detail. > > David > > > On 23/09/2016 3:52 PM, Lindenmaier, Goetz wrote: >> >> Hi, >> >> This change is part of the s390 port. It contains some basic adaptions >> needed for a full hotspot port for linux s390x. >> >> It defines the required macros, platform names and includes. >> >> The s390 port calles CodeCache::contains() in current_frame(), which is >> used in NMT. As NMT already collects stack traces before the CodeCache is >> initialized, contains() needs a check for this. >> >> Wherever a row of platforms are listed, I sorted them alphabetically. >> >> The jdk requires the file jvm.cfg. >> >> Please review. I please need a sponsor. >> http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/hotspot.wr01/ >> http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/jdk.wr01/ >> >> Best regards, >> Goetz. >> >
