Hi Joe, Roger,
Modified based on your latest comments, please check the new webrev:
http://cr.openjdk.java.net/~mli/8085192/webrev.02/
At the same time, I think Chris's idea is great.
Thank you
-Hamlin
On 2016/9/30 7:14, Joseph D. Darcy wrote:
If Hamlin's approach is taken in the end, I think having a smaller
retry count (5 or 10 rather than 20) would be more appropriate to
avoid making the worst-case running time longer than necessary.
Cheers,
-Joe
On 9/29/2016 6:55 AM, Roger Riggs wrote:
Hi Hamlin,
One more suggested improvement. Instead of two copy/paste copies of
the launch with options code,
it would cleaner to create a separate RMID.launch(String[] options)
method that would be passed the extra arguments.
Use it in forceLogSnapshot.java and ShutdownGracefully.java.
The (current) no-arg version could call the version with args with an
empty array(or null).
There would be only 1 copy of the launch algorithm.
Roger
