On 2016-10-01 02:41, Martin Buchholz wrote:
https://bugs.openjdk.java.net/browse/JDK-8167002
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/xml-id-validation-by-hash/


+1, but I have to ask what the intended benefit of writing:

  ((fIds != null) ? fIds : (fIds = new HashSet<>())).add(name);

rather than keeping the pre-existing pattern:

  if (fIds == null) fIds = new HashSet<>();
  fIds.add(name);

If this is about bytecode optimization to help with inlining or such,
the latter actually generate a more compact method (14 vs 16 bytecodes).

/Claes

Reply via email to