> On Oct 11, 2016, at 11:07 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 11/10/2016 19:03, Mandy Chung wrote: > >> This patch updates jar, jlink, jmod tool to be a provider of the new tool >> SPI. Some tests are also updated to replace the use of internal APIs with >> ToolProvider::findFirst to look up a tool provider. There are more tests >> that can be updated and something to be cleaned up in the future. >> >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.00/index.html >> > This update to the tools looks good. For the tests then > ToolProvider.findFirst("jar").get() will draw the attention of the optional > police and might be better to use orElseThrow to supply an exception that > clearly indicates that the tool cannot be found.
Good suggestion. Will change that before pushing. Thanks Mandy
