Hi Goetz, the change looks good except the two throws declarations in:
test/sun/tools/jhsdb/BasicLauncherTest.java test/sun/tools/jhsdb/HeapDumpTest.java I think "throws Exception" should be enough - we don't need "throws IOException, Exception". Thanks, Volker PS: we should really get rid of jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java in favour of test/lib/jdk/test/lib/Platform.java. Does anybody know if there's already a bug to track that? On Wed, Nov 2, 2016 at 2:16 PM, Lindenmaier, Goetz <goetz.lindenma...@sap.com> wrote: > Hi, > > This are the changes needed to the tests in the jdk repository > to work with s390. > In test/sun/tools/jhsdb I just use the other Platform.java which > gets it's shouldSAAttach() method changed to return 'false' on > S390. (I sent that part of the change to the hs-compiler list.) > > test/java/awt/JAWT/JAWT.sh is just skipped. > > Please review this change. > http://cr.openjdk.java.net/~goetz/wr16/8166837-jtreg_fixes/jdk-wr.01/ > > Best regards, > Goetz.
