On 11/02/2016 11:27 AM, David Holmes wrote:
Moving discussion to core-libs-dev. Please follow-up there.

Thanks,
David

On 3/11/2016 1:20 AM, Dmitry Zhikharev wrote:
Hi!

ForkJoinPool class documentation says nothing about it using daemon
threads since Java 8
(https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ForkJoinPool.html,

Right; thanks.
The sentence previously mentioning this in passing was changed,
leaving no mention of daemon status. We should add one:

***************
*** 37,43 ****
   * tasks are submitted to the pool from external clients.  Especially
   * when setting <em>asyncMode</em> to true in constructors, {@code
   * ForkJoinPool}s may also be appropriate for use with event-style
!  * tasks that are never joined.
   *
   * <p>A static {@link #commonPool()} is available and appropriate for
   * most applications. The common pool is used by any ForkJoinTask that
--- 37,44 ----
   * tasks are submitted to the pool from external clients.  Especially
   * when setting <em>asyncMode</em> to true in constructors, {@code
   * ForkJoinPool}s may also be appropriate for use with event-style
!  * tasks that are never joined. All worker threads are initialized
!  * with {@link Thread#isDaemon} set {@code true}.
   *
   * <p>A static {@link #commonPool()} is available and appropriate for
   * most applications. The common pool is used by any ForkJoinTask that



see also
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/0086eb10182b/src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java).

It was there in Java 7 documentation:
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ForkJoinPool.html
(see "Sample Usage").

I think it's an important note about ForkJoinPool and should be added
back.

Regards, Dmitry Zhikharev



Reply via email to