Looks good,
the static methods in ImmutableCollections do not need to be final there are 
already static.

Rémi 

On November 4, 2016 3:08:58 AM GMT+01:00, Stuart Marks 
<[email protected]> wrote:
>Hi all,
>
>Please review this small set of changes to the immutable collections to
>make the 
>zero-size instances singletons. (JDK-8156079)
>
>This also includes a couple other small optimizations (JDK-8169222) to
>change 
>the expansion factor from floating point to integer, and also to avoid
>creating 
>a single-use Random instance to compute the hash salt value at startup.
>
>Webrev:
>
>     http://cr.openjdk.java.net/~smarks/reviews/8156079/webrev.0/
>
>Thanks,
>
>s'marks

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Reply via email to