Applied changes to http://cr.openjdk.java.net/~reinhapa/reviews/8168836/webrev.00
-Patrick On 15.11.2016 00:20, Mandy Chung wrote: >> On Nov 14, 2016, at 1:22 PM, Patrick Reinhart <patr...@reini.net> wrote: >> >> Ups, previous mail contained wrong URL. Here’s the correct one: >> >> http://cr.openjdk.java.net/~reinhapa/reviews/8168836/webrev.00 > 879 log.println(getMessage("err.missing.dependences")); > > This should call reportError method that will prepend with “error.prefix”. > So no need to have “ERROR:” in “err.missing.dependences” message. > > Formatting Nit: line 541-542 and line 753-754 align to the first parameter of > the method. > > Otherwise looks good. I can sponsor it. > > Mandy > > > >
