> On 16 Nov 2016, at 17:02, Brent Christian <[email protected]> wrote:
> 
> On 11/16/16 3:44 PM, Paul Sandoz wrote:
>> Hi Brent,
>> 
>> I think it would be better to use Objects.requireNonNull
> 
> Yes, thank you - forgot about that.
> 
>> IMHO no need to specify a exception message, or test for that (which i think 
>> is too brittle).
> 
> OK.
> 
> Updated webrev:
> http://cr.openjdk.java.net/~bchristi/8136831/webrev.01/
> 

Looks ok, but has indicated by Alan i would leave Class alone and untested 
until Jake gets integrated, then follow up with another issue.


>> You will need to file a CCC for the change in behaviour of the Enumeration 
>> returning getResources.
> 
> And for the new @throws, I should think.
> 

Yes.

Thanks,
Paul.

Reply via email to