> On Nov 16, 2016, at 7:00 AM, Jim Laskey (Oracle) <[email protected]>
> wrote:
>
> Sorts options by full name
>
> http://cr.openjdk.java.net/~jlaskey/8168256/webrev/index.html
> https://bugs.openjdk.java.net/browse/JDK-8168256
>
113 public Option(boolean hasArg, Processing<T> processing, String
name, String shortcut) {
114 this(hasArg, processing, false, name, "");
115 }
should be this(hasArg, processing, false, name, shortcut);
152 } else if (trimmedName.startsWith("-")) {
153 trimmedName = trimmedName.substring(1);
154 }
Per JEP 293, jlink is a new tool that should have long form option names. This
can be simplified (these 2 lines not needed) and the resource bundle key uses
the long form name. Option constructor should validate the name parameter with
two slashes prefix.
Otherwise, looks good.
Mandy
