Hi Frank, to me this looks fine. Maybe a small cosmetical thing: Around lines 212 and 240 you could remove the additional empty lines to have one blank line between methods as in the rest of the file.
Note that I'm not a reviewer. Best regards Christoph From: Frank Yuan [mailto:[email protected]] Sent: Mittwoch, 23. November 2016 05:41 To: [email protected]; 'Daniel Fuchs' <[email protected]>; Langer, Christoph <[email protected]>; 'Volker Simonis' <[email protected]>; 'Joe Wang' <[email protected]> Cc: [email protected]; [email protected] Subject: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars Hi All Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/? Bug: https://bugs.openjdk.java.net/browse/JDK-8170192 This patch is fully same as Daniel provided except a few lines of additional cleaning, thanks to Daniel for providing the patch! Thanks Frank
