Thanks Lance!
I've re-created the webrev with the one-line change:
webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/jdk9/8167340/webrev/>
Advertising
I'll use https://bugs.openjdk.java.net/browse/JDK-8170556 for the
cleanup, will expand to cover the stream package, but leave the impl
package for a later time.
Thanks,
Joe
On 11/30/16, 5:07 PM, Lance Andersen wrote:
Hi Joe
Looks OK.
I might suggest a separate issue for the cleanup and just have this
bug address the bug fix
Best
Lance
On Nov 30, 2016, at 4:21 PM, Joe Wang <huizhe.w...@oracle.com
<mailto:huizhe.w...@oracle.com>> wrote:
Hi,
Please review an one-line fix and a bunch of cleanups.
The reported issue was caused by a missed setting when the
XMLStreamReader initializes the XML 1.1 scanner, so while the
changeset involved 350 lines, the fix is really just the following:
XMLStreamReaderImpl.java:
@@ -605,11 +604,12 @@
...
+ fEntityScanner.registerListener(fScanner);
All other changes are cleanups, warnings. And BTW, warnings in the
jaxp repo have come down from 5230 in 2015 to 3265, a result of a bit
of cleanups here and there when we touch those classes. Still a long
way to go, and it shows we may need to have a few dedicated patches.
JBS: https://bugs.openjdk.java.net/browse/JDK-8167340
webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/jdk9/8167340/webrev/>
Thanks,
Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
