Hi Joe Thank you very much for your comments!
I have made a new webrev http://cr.openjdk.java.net/~fyuan/8087303_8114834/webrev.01/ as your suggestions, please check. Thanks Frank > -----Original Message----- > From: Joe Wang [mailto:[email protected]] > Subject: Re: RFR (JAXP) JDK-8087303 LSSerializer pretty print does not work > anymore and JDK-8114834 LSSerializerImpl always serializes an > entity reference node to" &entityName;" even if "entities" property is false > > Hi Frank, > > Thanks for the diligent work! I think we've made a great improvement > over the PrettyPrint (tremendous ;-) ) > > Could you look into extracting the XML literal strings in the test into > plain files (similar to the other 'gold' files)? What I'm hoping to see > is that they'd look easily prettier in a text editor, and for that > matter, the original xml files were a mess. > > The tests set PrettyPrint, and by default for html. It would be good to > test the cases when it's turned off, that would help verify the > non-pretty format was not changed. > > Thanks, > Joe > > On 12/13/16, 6:55 AM, Frank Yuan wrote: > > Hi all > > > > Webrev http://cr.openjdk.java.net/~fyuan/8087303_8114834/webrev.00/ is for > > JDK-8087303 and JDK-8114834, I have to combine the fix > > because there is some interaction between them. > > Bugs: https://bugs.openjdk.java.net/browse/JDK-8087303 > > https://bugs.openjdk.java.net/browse/JDK-8114834 > > > > Besides fixed some issues in xml serializer, I made the following changes > > in this patch: > > 1. refined the handling for whitespace text > > 2. added support for xml:space attribute > > 3. changed the default indentation to 4 > > 4. refined the handling for HTML block element and inline element > > > > Would you like to have a look at this review? > > > > Thanks, > > > > Frank > > > >
