Hi Joe,

This looks fine to me. I’ve just a few picayune items:

1. FdLibm

Line 649: I assume the weird “halF” (upper case F) is retained in order to 
match the original C code.

2. TEST.ROOT

Line 30: The jtreg required version is reverted.

3. ExpTests

Lines 65 and 69: The threshold values in comments could be static final 
constants as well as they are used at lines
66, 70, 109 and 112.

Thanks,

Brian

On Dec 15, 2016, at 12:25 PM, joe darcy <joe.da...@oracle.com> wrote:

> Next up in porting fdlibm to Java after cbrt (JDK-8136799), pow (JDK-8134795) 
> and hypot (JDK-7130085) earlier in JDK 9 is exp:
> 
>    JDK-8139688 Port fdlibm exp to Java
>    http://cr.openjdk.java.net/~darcy/8139688.5/
> 
> Same methodology followed as when porting the earlier functions.

Reply via email to