Thanks, Brian. I've also added it to our nightly verification run and if all goes well I'll push it tomorrow.
Best regards Christoph > -----Original Message----- > From: Brian Burkhalter [mailto:brian.burkhal...@oracle.com] > Sent: Donnerstag, 22. Dezember 2016 18:17 > To: Langer, Christoph <christoph.lan...@sap.com> > Cc: core-libs-dev@openjdk.java.net; ppc-aix-port-...@openjdk.java.net; nio- > d...@openjdk.java.net > Subject: Re: RFR(S): 8171906: Changes for 8148023 break AIX build > > Hi Christoph, > > I ran this patch through our regression test suite against the NIO tests and > it > built and passed the test on all platforms (Linux, OS X, Solaris, Windows). > So it's > +1 on the review. > > Thanks, > > Brian > > On Dec 22, 2016, at 8:27 AM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > > Hi Christoph, > > > > It looks OK, but have you built it on the other Unix platforms? If > > necessary I > could run it through our regression suite first. > > > > Thanks, > > > > Brian > > > > On Dec 22, 2016, at 7:58 AM, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > > >> no problem. So, may I consider this reviewed? > >> > >> From: Brian Burkhalter [mailto:brian.burkhal...@oracle.com] > >> Sorry about that. There seems to a surprising lack of consistency for this > across the platforms.
