Hi Roger,
Thank you for reviewing. Please check comments inline.
On 2017/1/12 9:05, Roger Riggs wrote:
Hi Hamlin,
ClassPathCodebase:
- line 51: The comment says seconds but it is really milliseconds.
Yes, the comment little bit confusing, modified as "dozens of seconds",
as it will wait for N*10000 milliseconds.
security.policy:
- line 21: "this its" -> "its"
fixed.
- line 26: Is the relative path in the File permission correct;
Is there a ${test.xxx} path to refer to that file.
yes, JavaVM.getCodeCoverageOptions will need the access to the relative
path.
registry.security.policy: Add a comment saying how this policy is
used (to distinguish it from the other security policy).
added.
Otherwise looks fine,
code is pushed.
Thank you
-Hamlin
Roger
On 1/11/2017 11:33 PM, Hamlin Li wrote:
Would you please review the below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8030950
webrev: http://cr.openjdk.java.net/~mli/8030950/webrev.00/
Thank you
-Hamlin
