Hi Rob,

I believe you should move the security check to before
the class is actually loaded, before the call to
 171             List<String> urls = getDnsUrls(url, env);

best regards,

-- daniel

On 25/01/17 17:44, Rob McKenna wrote:
I neglected to include a security check so I've cribbed the one from
OBJECT_FACTORIES (NamingManager.setObjectFactoryBuilder()) - see:

http://cr.openjdk.java.net/~robm/8160768/webrev.02/

Note, this wraps the SecurityException in a NamingException. Presumably
its better to throw something than simply leave the default value in
place, but feedback appreciated!

    -Rob

On 25/01/17 04:31, Rob McKenna wrote:
Hi folks,

I'm looking for feedback on this suggested fix for the following bug:

https://bugs.openjdk.java.net/browse/JDK-816076
http://cr.openjdk.java.net/~robm/8160768/webrev.01/

This is something that has come up a few times. Basically in certain
environments (e.g. MS Active Directory) there is a dependence on
DNS records to provide a pointer to the actual ldap server to be used
for a given LdapCtx.PROVIDER_URL where the url itself simply points to the
domain name.

This fix add a new Ldap context property which allows a user to specify a
class (implementing BiFunction) which can perform any necessary extra steps
to derive the ldap servers hostname/port from the PROVIDER_URL.

    -Rob


Reply via email to