Hi Henry,
I was somewhat surprised to see changes to launcher_LANG.properties, I usually make the change in the english/default locale and allow the L1ON team to make the locale specific changes, but if you are confident of the changes, that is fine.
src/java.base/share/native/libjli/args.c + // Check if Main class specified after argument checked + // Must be after expansion so we can caught if main class specified @argfile Is my interpretation accurate ? If so please reword it accordingly. /* * Check if main-class is specified after argument being checked, it * must always appear after expansion, as a main-class specified in * an @argfile is not allowed, and it must be caught now. */ + assert (*env == '\0' || isspace(*env)); asserts are not enable in product builds, is the intention only for debug builds ? Should this be flagged as a warning or something under tracing ? src/java.base/windows/native/libjli/cmdtoargs.c - // iterate through rest of coammand line + // iterate through rest of command line Thanks Kumar
Hi, Please review the webrev[1] that add support for JAVA_OPTIONS environment variable. The bug[2] describes how JAVA_OPTIONS works. [1] http://cr.openjdk.java.net/~henryjen/jdk9/8170832/4/webrev/ [2] https://bugs.openjdk.java.net/browse/JDK-8170832 Cheers, Henry
