> On Jan 26, 2017, at 10:58 PM, Xueming Shen <[email protected]> wrote: > > Hi, > > Please review the change for JDK-8173396. > > issue: https://bugs.openjdk.java.net/browse/JDK-8173396 > webrev: http://cr.openjdk.java.net/~sherman/8173396/webrev > > The error message keys "error.versioned.xxxx" were renamed to > error.validator.xxxx > in all resource properties files but several use site rename/change was > missed in > method checkModuleDescriptor(). >
The change looks okay. This reminds me that this string-based keys are easy to miss if renamed. javac generates the constant variables at build time that avoids this kind of regression but they are not in source which is its downside. Mandy
