Hi Brian, Thank you for the quick review.
I will defer to Bill on whether anything else should be added as it should be included in the standalone JAF RI as well. Bill, let us know. :-) Best Lance > On Feb 7, 2017, at 2:56 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > Hi Lance, > > +1 > > Good thing especially given that PNG is now two decades old. ;-) > > Are there other now-common media types which should also be added, e.g., > anything that QuickTime, WMP, VideoLAN, iTunes, Preview, etc. would typically > handle? See, e.g., https://bugs.openjdk.java.net/browse/JDK-8162745 > <https://bugs.openjdk.java.net/browse/JDK-8162745> and others ... > > Thanks, > > Brian > > On Feb 7, 2017, at 11:32 AM, Lance Andersen <lance.ander...@oracle.com > <mailto:lance.ander...@oracle.com>> wrote: > >> Attached is the diff to update the mimetypes.default for JAF. The >> standalone standalone JAF was updated with support for .png files some time >> ago. >> >> >> ——————— >> hg diff >> diff -r 7c829eba7814 >> src/java.activation/share/classes/META-INF/mimetypes.default >> --- a/src/java.activation/share/classes/META-INF/mimetypes.default Sat Feb >> 04 14:03:15 2017 -0500 >> +++ b/src/java.activation/share/classes/META-INF/mimetypes.default Tue Feb >> 07 14:23:23 2017 -0500 >> @@ -7,6 +7,7 @@ >> image/ief ief >> image/jpeg jpeg jpg jpe JPG >> image/tiff tiff tif >> +image/png png PNG >> image/x-xwindowdump xwd >> application/postscript ai eps ps >> application/rtf rtf >> ljanders-mac:jaxws ljanders$ >> —————————— > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
