Re: RFR(s): 8174194: Several java/lang tests failing due to undeclared module dependencies.

[Sergei Kovalev]

Hi Mandy,

Thank you for review and remarks.

http://cr.openjdk.java.net/~skovalev/8174194/webrev.01/


08.02.17 19:06, Mandy Chung wrote:

On Feb 8, 2017, at 6:13 AM, Sergei Kovalev <sergei.kova...@oracle.com> wrote:

Thank you for review.

On 08/02/17 13:51, Sergei Kovalev wrote:
WebRev: http://cr.openjdk.java.net/~skovalev/8174194/webrev.00/

CheckPackageAccess.java
   86             System.out.println(String.format(MODULE_TEXT, moduleName, isModulePresent ? 
"" : " NOT"));

this can be simplified with:

System.out.format(MODULE_TEXT, moduleName, isModulePresent ? "" : " NOT”);

I suggest to inline MODULE_TEXT in this method as it’s clear what it’s printed. 
 No need for MODULE_TEXT varaiable.  Please wrap long lines.

LFSingleThreadCachingTest.java
   - can you keep @modules in alphatical order.

thanks
Mandy

--
With best regards,
Sergei