On 14/02/17 17:21, huizhe wang wrote:
Thanks!
Here's an updated webrev:
http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
+1
-- daniel
-Joe
On 2/14/2017 4:07 AM, Lance Andersen wrote:
Looks good overall Joe. I would agree that I would clean up the minor
comment alignment issues.
Best
Lance
On Feb 13, 2017, at 9:27 PM, huizhe wang <huizhe.w...@oracle.com
<mailto:huizhe.w...@oracle.com>> wrote:
A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for
the coming development deadline.
JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
<http://cr.openjdk.java.net/%7Ejoehw/jdk9/8169450/webrev/>
Checking whether a space follows "<?xml" was sufficient for DOM/SAX
for which the base parser was originally created since the xml
declaration was normalized during version detection. StAX, sharing
the base parser after it was added to the JDK, however, does not use
the same version detection/normalization process and would
incorrectly parse the declaration if there are other whitespaces.
Thanks,
Joe
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
