Looks fine Sherman.. > On Feb 14, 2017, at 2:09 PM, Xueming Shen <xueming.s...@oracle.com> wrote: > > Hi, > > Please review the test change for JDK-8174248 > > issue: https://bugs.openjdk.java.net/browse/JDK-8174248 > webrev: http://cr.openjdk.java.net/~sherman/8174248/webrev > > The change is to simply rename the entry name from "IAmNotTheEntryPoint" > to a "packaged" one as " jdk.test.foo.IAmNotTheEntryPoint" to satisfy the > newly added sanity check in j.l.m.ModuleDescriptor.Builder.mainClass(), in > which the "main-class in unnamed package" is no longer allowed (and the > named package must exist in module "packages") . > > Arguably it might be desired for "jar" tool to also verify whether or not the > "main-class" really exists in the module jar file (the implementation does not > verify the existence of the main-class for the manifest for now, the newly > added module related code follows the "convention"), but this probably should > be handled/discussed in a separate rfe. > > Thanks, > Sherman
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
