On 3/24/17 7:03 PM, Daniel D. Daugherty wrote:
On 3/24/17 2:12 PM, Chris Plummer wrote:
Hello,
Please review changes for the following:
http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/
> http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/webrev.hotspot/
test/runtime/Thread/TooSmallStackSize.java
No comments.
> http://cr.openjdk.java.net/~cjplummer/8177015/webrev.00/webrev.jdk/
src/java.base/share/native/libjli/java.c
No comments.
test/tools/launcher/TooSmallStackSize.java
L170: * Try again with a the minimum stack size plus a
bit more so it is not
Typo: 'with a the' -> 'with the'
Thumbs up. I don't need to see a new webrev if you fix the typo.
Thanks, Dan!
Chris
Dan
https://bugs.openjdk.java.net/browse/JDK-8177015
The CR description explains the problem. I'm increasing the minimum
allowed -Xss stack size from 32k to 64k. There are also a couple of
tests that were testing for -Xss32k that I updated to 64k. I also
added a new test case for 253k. This is something I intended to do
for JDK-8176768, but forgot to include the change in the review. It's
not really related to this CR, but I figured I'd drop it in since I'm
making other changes to the file.
thanks,
Chris
