Hi,

The test.dir property seems like a convenience for the test developer.
It is not defined by jtreg in the tag specification as are the other properties [1]. It is not widely used in tests but could be understandable when manually testing to
avoid cluttering the working directory with test files.


On the original webrev:
In addition to checking if the directory exists would you want to list its contents?

And if checking the status of zpath, list its permission attributes?

Is there any chance that a previous delete of zpath has not completed, (since windows
has the delayed delete if the file is in use behavior).
I think can't think why that would be intermittent though.

$.02, Roger

[1] http://openjdk.java.net/jtreg/tag-spec.html#testvars

On 4/26/2017 11:15 AM, Brian Burkhalter wrote:
I was wondering whether test.dir is there to allow to direct to large disks if large files are involved. This is a general observation, not just for this test.

Brian

On Apr 26, 2017, at 6:37 AM, Roger Riggs <roger.ri...@oracle.com <mailto:roger.ri...@oracle.com>> wrote:

I would keep it simple and use the current form. It make it easy to run the tests standalone.
 dir = System.getProperty("test.dir", ".")

Adding in the additional "user.dir" variant just complicates the code and understanding without improving the use cases. (by default user.dir is set to the absolute pathname of ".").


Reply via email to